transpile: Properly handle address-of static compound literals#1644
Open
Rua wants to merge 5 commits intoimmunant:masterfrom
Open
transpile: Properly handle address-of static compound literals#1644Rua wants to merge 5 commits intoimmunant:masterfrom
Rua wants to merge 5 commits intoimmunant:masterfrom
Conversation
Rua
force-pushed
the
static-compound-literal
branch
from
dcbe0fa to
8a200eb
Compare
Rua
force-pushed
the
static-compound-literal
branch
4 times, most recently
from
4a06d79 to
b768426
Compare
kkysen
reviewed
Mar 10, 2026
c2rust-transpile/tests/snapshots/snapshots__transpile@compound_literals.c.2021.snap
Show resolved
Hide resolved
Rua
force-pushed
the
static-compound-literal
branch
4 times, most recently
from
3e04701 to
e485aae
Compare
Rua
force-pushed
the
static-compound-literal
branch
from
e485aae to
2be8ad5
Compare
Contributor
Author
|
I realised that in the current nightly, taking the raw address of a static is |
Rua
force-pushed
the
static-compound-literal
branch
from
2be8ad5 to
3d6951c
Compare
Rua
force-pushed
the
static-compound-literal
branch
from
3d6951c to
dccadf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithStmtsin static initialisers to contain statements #1610.This allows limited use of statements in translations of statics, only if the statements are
Stmt::Item. This is then used to solve the original bug, by declaring a fresh static variable to take the address of.This code doesn't currently account for situations in which the compound literal expression needs to be sectioned off for late initialisation, as that would have complicated the code a fair bit further.