Open
Conversation
Clang 22 removes `ElaboratedType` and now represents `size_t`/`ssize_t`/`ptrdiff_t` using `PredefinedSugarType` (see llvm PR #143653)
fw-immunant
commented
Mar 17, 2026
Comment on lines
-2227
to
-2228
| auto t = D->getTypeForDecl(); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
These are unused and the getTypeForDecl method no longer exists in Clang 22.
kkysen
reviewed
Mar 18, 2026
| .expect("Predefined sugar type kind not found"); | ||
|
|
||
| // See `clang::PredefinedSugarKind`. | ||
| let predef_sugar_ty = match kind { |
Contributor
There was a problem hiding this comment.
Does this affect the portable type code?
Contributor
There was a problem hiding this comment.
PredefinedSugarKind seems to be similar to what we're doing with the portable types, but just for size_t, ssize_t, and ptrdiff_t, so I'm wondering if we need to handle this specially.
ahomescu
reviewed
Mar 18, 2026
| VisitQualType(t); | ||
| } | ||
|
|
||
| #if CLANG_VERSION_MAJOR < 22 |
Contributor
There was a problem hiding this comment.
Do we indent preprocessor directives? In most projects, they start at column 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.