transpile: Make paren resolving explicit, consistently use [ ] for indexing#1682
Closed
Rua wants to merge 10 commits intoimmunant:masterfrom
Closed
transpile: Make paren resolving explicit, consistently use [ ] for indexing#1682Rua wants to merge 10 commits intoimmunant:masterfrom
[ ] for indexing#1682Rua wants to merge 10 commits intoimmunant:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c_astsubmodules #1652.impl Index<CExprId> for TypedAstContextcontains a footgun that caught me off guard: it automatically resolves anyParenexpression. Usually that's "the right thing", but it can also silently introduce problems when it unexpectedly skips over an intermediate expression. Additionally, there is no way to avoid this behaviour;TypedAstContexthas no method to retrieve the actual expression matching theCExprId.To avoid that happening in the future and make things more explicit, this PR adds
resolve_parensto indexing expressions where it makes sense, and removes the automatic resolving. It also adds a second commit to make everything use[ ]syntax for the sake of consistency.