Skip to content

feat(sale): Surface vendor errors from custom webooks#2802

Merged
JCSanPedro merged 4 commits intomainfrom
BSB-32-primary-sale-custom-errors
Mar 18, 2026
Merged

feat(sale): Surface vendor errors from custom webooks#2802
JCSanPedro merged 4 commits intomainfrom
BSB-32-primary-sale-custom-errors

Conversation

@JCSanPedro
Copy link
Contributor

Hi👋, please ensure the PR title follows the below standards:

  • PR is titled with conventional commit style naming: type(scope): message. For example: feat(passport): my new feature
  • If you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities, add a ! after the type(scope), for example feat(passport)!: my new breaking feature

Summary

This change to the primary sales api will return the vendor's custom error if either the quote or signing step fails due to the vendor's webhooks return a 400/403/404 response.

This PR updates the SaleErrorView such that it will render the vendor's custom error if present.

image

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

@JCSanPedro JCSanPedro requested a review from a team as a code owner March 18, 2026 05:14
@nx-cloud
Copy link

nx-cloud bot commented Mar 18, 2026

View your CI Pipeline Execution ↗ for commit 3fe4458

Command Status Duration Result
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 4s View ↗
nx affected -t build,lint,test ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-18 23:24:52 UTC

export type SignOrderError = {
type: SaleErrorTypes;
data?: Record<string, string>;
data?: Record<string, unknown>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unknown?

@JCSanPedro JCSanPedro enabled auto-merge March 18, 2026 23:14
@JCSanPedro JCSanPedro added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 5c69eda Mar 18, 2026
7 checks passed
@JCSanPedro JCSanPedro deleted the BSB-32-primary-sale-custom-errors branch March 18, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants