Skip to content

Fix double precision truncation to single precision in FFT - #20

Merged
qianglbl merged 1 commit into
impact-lbl:masterfrom
ken-lauer:fix_fft_truncation
Aug 21, 2026
Merged

Fix double precision truncation to single precision in FFT#20
qianglbl merged 1 commit into
impact-lbl:masterfrom
ken-lauer:fix_fft_truncation

Conversation

@ken-lauer

Copy link
Copy Markdown
Contributor

This brings in the FFT.f90 module from IMPACT-T along with fixes from impact-lbl/IMPACT-T#35.

Floating point values when written as strings in Fortran syntax:

  • E specifies single precision (32-bit, real).
  • D specifies double precision (64-bit, double precision)

Despite being real(kind=8) defining them as 0...E+... led to truncating the constant.
This should resolve some issues with FFT dimensions that are a factor of 3 or 5.

@ken-lauer
ken-lauer marked this pull request as ready for review August 19, 2026 16:53
@qianglbl
qianglbl merged commit 7f39c4f into impact-lbl:master Aug 21, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants