[C vecextensions target]#577
Closed
sv2518 wants to merge 7 commits intoinducer:c_vecextensions_targetfrom
Closed
Conversation
kaushikcfd
approved these changes
Mar 11, 2022
Collaborator
kaushikcfd
left a comment
kaushikcfd
left a comment
There was a problem hiding this comment.
Left some minor suggestions. We can merge this after that, thanks!
Co-authored-by: Kaushik Kulkarni <15399010+kaushikcfd@users.noreply.github.com>
kaushikcfd
force-pushed
the
c_vecextensions_target
branch
from
b1982b8 to
6ea1c80
Compare
Collaborator
|
To keep a clean commit history in #557, manually pushed this patch over there. Thanks! (Closing this as it was merged manually) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are two fixes