rename_inames: replace old inames that appear as params in other domains#727
Open
isuruf wants to merge 1 commit intoinducer:mainfrom
Open
rename_inames: replace old inames that appear as params in other domains#727isuruf wants to merge 1 commit intoinducer:mainfrom
isuruf wants to merge 1 commit intoinducer:mainfrom
Conversation
isuruf
force-pushed
the
rename_inames
branch
3 times, most recently
from
31a21ac to
19dc291
Compare
inducer
force-pushed
the
rename_inames
branch
from
19dc291 to
150ff1f
Compare
inducer
reviewed
Jan 12, 2023
Comment on lines
+2409
to
+2416
| new_domains = [] | ||
| for dom in kernel.domains: | ||
| for old_iname in orig_old_inames: | ||
| d = dom.get_var_dict() | ||
| if old_iname in d and new_iname not in d: | ||
| var_type, var_num = d[old_iname] | ||
| dom = dom.set_dim_name(var_type, var_num, new_iname) | ||
| new_domains.append(dom) |
Owner
There was a problem hiding this comment.
As it stands, this is not quite correct. The old iname may survive, and it may remain in use (if within is given). In that case, I suggest we raise an (not-implemented) error if the iname occurs as a parameter to another domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #726