fix(tui): esc back-navigation; multi-select Enter stops force-selecting#264
Open
initializ-mk wants to merge 1 commit into
Open
fix(tui): esc back-navigation; multi-select Enter stops force-selecting#264initializ-mk wants to merge 1 commit into
initializ-mk wants to merge 1 commit into
Conversation
…rce-selecting Two init-wizard UX fixes: - Back navigation: esc now goes back one step from ANY step (handled at the wizard level so it works regardless of a step's sub-phase or text inputs — esc is never an editing key). ctrl+c cancels; esc on the first step cancels since there is nowhere to go back. Previously only a few steps emitted a backspace-back, so most screens had no way back. Key hints updated to 'esc back'. - Multi-select Enter: pressing Enter with nothing toggled now confirms an EMPTY selection instead of silently auto-checking the highlighted row. The cursor is just the highlight; Space toggles. Steps like Skills / Fallback legitimately allow selecting nothing. Tests: wizard esc-back (and first-step cancel); multi-select enter-confirms-empty, space+enter, and cursor-move+space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
forge initwizard UX fixes from TUI feedback.1. Back-navigation everywhere (
esc)Previously only a few steps (review / fallback / egress) emitted a backspace-back; most screens had no way to go back. Now
escgoes back one step from any step, handled at the wizard level so it works regardless of a step's sub-phase or text inputs (escis never an editing key, so intercepting it there is safe).esc→ previous step (re-initialized).escon the first step → cancel (nowhere to go back).ctrl+c→ cancel (unchanged).esc quit→esc back.2. Multi-select
Enterstops force-selecting the highlighted rowThe multi-select confirmed on
Enterby auto-checking the cursor row when nothing was toggled — so "just press Enter" silently selected whatever was highlighted, even though Space is the toggle key. NowEnterconfirms exactly what Space toggled, including an empty selection. Steps like Skills / Fallback legitimately allow selecting nothing.Tests
wizard_nav_test.go—escsteps back from step 2→1→0, and cancels on the first step.multi_select_test.go—Enterconfirms empty;Space+Enterselects the cursor row; cursor-move thenSpacetoggles the correct row.Build +
golangci-lintclean;forge-cli/internal/tui/...tests green.Companion to #263 (drop builtin-tool selection screen; web search gets its own step) — same wizard, independent changes.