Fix PHP 8.4 deprecations#25
Open
daniloalvess wants to merge 2 commits into
Open
Conversation
daniloalvess
force-pushed
the
fix/deprecation-notices-php-84
branch
from
254c6c9 to
1ac107e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
PHP 8.4 deprecates implicitly nullable types. PHP applications are recommended to explicitly declare the type as
nullable. All type declarations that have a default value ofnull, but without declaringnullin the type declaration, emit a deprecation notice.What is the current behavior? (You can also link to an open issue here)
It produces a deprecation notice.
What is the new behavior (if this is a feature change)?
The deprecation notice should be gone.
Other information
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated