Skip to content

feat(ui-color-picker): rework ColorPicker#2439

Merged
balzss merged 1 commit intov12from
INSTUI-4789-color-picker-rework2
Mar 13, 2026
Merged

feat(ui-color-picker): rework ColorPicker#2439
balzss merged 1 commit intov12from
INSTUI-4789-color-picker-rework2

Conversation

@ToMESSKa
Copy link
Copy Markdown
Contributor

@ToMESSKa ToMESSKa commented Mar 10, 2026 •
edited
Loading

INSTUI-4789

ISSUE:

  • ColorPicker, ColorContrast, ColorIndicator, ColorPixer and ColorPreset need to be migrated to the new theming system

TEST PLAN:

  • check if the components work the same as before in v1 (these are token-only components)
  • check if the components and the examples work in v2 (especially the dark theme)
  • check if all necessary the imports are renamed to v11_6 in v1
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in packages/ui-color-picker/src/exports/b.ts and packages/ui-color-picker/src/exports/a.ts
  • check if the packages/ui-color-picker/package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide
  • check if the index.ts files use withStyle instead of withStyleLegacy

@ToMESSKa ToMESSKa self-assigned this Mar 10, 2026
ToMESSKa
ToMESSKa commented Mar 10, 2026
View reviewed changes
Comment thread packages/__docs__/src/App/index.tsx Outdated
Comment on lines +572 to +575
// const showRebrandThemes =
// this.state.showMinorVersionSelector &&
// this.state.selectedMinorVersion !== 'v11_6'
const showRebrandThemes = true // TODO temp workaround
Copy link
Copy Markdown
Contributor Author

@ToMESSKa ToMESSKa Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to see the v2 in the PR preview

Copy link
Copy Markdown
Contributor

@balzss balzss Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed anymore, you can rebase the the latest v12 and it should work and this can be removed

ToMESSKa
ToMESSKa commented Mar 10, 2026
View reviewed changes
Comment thread packages/ui-color-picker/package.json Outdated
Comment on lines +77 to +80
"types": "./types/exports/b.d.ts",
"import": "./es/exports/b.js",
"require": "./lib/exports/b.js",
"default": "./es/exports/b.js"
Copy link
Copy Markdown
Contributor Author

@ToMESSKa ToMESSKa Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to see the v2 in the PR preview

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 10, 2026 •
edited
Loading

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-13 16:07 UTC

@ToMESSKa
Copy link
Copy Markdown
Contributor Author

ToMESSKa commented Mar 10, 2026

@hajnaldo please don't forget to review all these components ColorPicker, ColorContrast, ColorIndicator, ColorPixer and ColorPreset

@ToMESSKa ToMESSKa force-pushed the INSTUI-4789-color-picker-rework2 branch from d04fc91 to 732c170 Compare March 11, 2026 15:16
@ToMESSKa ToMESSKa mentioned this pull request Mar 12, 2026
Merged
joyenjoyer
joyenjoyer approved these changes Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the code, and the imports look good to me. Regardless of the buttons, the design looks okay too, and the examples on the docs page worked well.

@balzss balzss self-requested a review March 13, 2026 09:40
@ToMESSKa @claude @balzss
feat(ui-color-picker): rework ColorPicker
4934431 
INSTUI-4789

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@balzss balzss force-pushed the INSTUI-4789-color-picker-rework2 branch from 732c170 to 4934431 Compare March 13, 2026 15:48
balzss
balzss approved these changes Mar 13, 2026
View reviewed changes
Comment thread packages/__docs__/src/App/index.tsx Outdated
Comment on lines +572 to +575
// const showRebrandThemes =
// this.state.showMinorVersionSelector &&
// this.state.selectedMinorVersion !== 'v11_6'
const showRebrandThemes = true // TODO temp workaround
Copy link
Copy Markdown
Contributor

@balzss balzss Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed anymore, you can rebase the the latest v12 and it should work and this can be removed

@balzss balzss merged commit 3815aa5 into v12 Mar 13, 2026
8 of 9 checks passed
@balzss balzss deleted the INSTUI-4789-color-picker-rework2 branch March 13, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balzss balzss balzss approved these changes

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@hajnaldo hajnaldo Awaiting requested review from hajnaldo

@matyasf matyasf Awaiting requested review from matyasf

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ToMESSKa @balzss @joyenjoyer