Open
Conversation
|
8323c60 to
099e8ef
Compare
ToMESSKa
commented
Mar 17, 2026
Comment on lines
103
to
+104
| ref: handleElementRef, | ||
| name: iconName, |
Contributor
Author
There was a problem hiding this comment.
The svg had no name prop so the test could not find the custom filled star icon, so I added this.
INSTUI-4806
099e8ef to
133042f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4806
ISSUE:
TEST PLAN:
exports/b.tsandexports/a.tspackage.jsonuses the correct versioningsee this link to see the rework: https://instructure.design/pr-preview/pr-2461/v11_7/Rating