Skip to content

feat(ui-rating): rework Rating#2461

Open
ToMESSKa wants to merge 1 commit intomasterfrom
INSTUI-4806-rating-rework-multi
Open

feat(ui-rating): rework Rating#2461
ToMESSKa wants to merge 1 commit intomasterfrom
INSTUI-4806-rating-rework-multi

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 17, 2026

INSTUI-4806

ISSUE:

  • Rating needs to be migrated to the new theming system

TEST PLAN:

  • check if the component works the same as before in v1
  • check if the components and the examples work in v2 (especially the dark theme)
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in exports/b.ts and exports/a.ts
  • check if the package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide
  • check if the index.ts files use withStyle instead of withStyleLegacy
  • check if the v2 component uses all the tokens

see this link to see the rework: https://instructure.design/pr-preview/pr-2461/v11_7/Rating

@ToMESSKa ToMESSKa self-assigned this Mar 17, 2026
@github-actions
Copy link

github-actions bot commented Mar 17, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2461/

Built to branch gh-pages at 2026-03-17 12:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4806-rating-rework-multi branch from 8323c60 to 099e8ef Compare March 17, 2026 12:30
Comment on lines 103 to +104
ref: handleElementRef,
name: iconName,
Copy link
Contributor Author

@ToMESSKa ToMESSKa Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svg had no name prop so the test could not find the custom filled star icon, so I added this.

@ToMESSKa ToMESSKa force-pushed the INSTUI-4806-rating-rework-multi branch from 099e8ef to 133042f Compare March 17, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant