Skip to content

feat(ui-options,ui-select): rework Select#2465

Open
ToMESSKa wants to merge 1 commit intomasterfrom
INSTUI-4807-select-rework-multi
Open

feat(ui-options,ui-select): rework Select#2465
ToMESSKa wants to merge 1 commit intomasterfrom
INSTUI-4807-select-rework-multi

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 17, 2026

INSTUI-4807

ISSUE:

  • Select needs to be migrated to the new theming system

TEST PLAN:

  • check if the component works the same as before in v1
  • check if the components and the examples work in v2 (especially the dark theme)
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in exports/b.ts and exports/a.ts
  • check if the package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide
  • check if the index.ts files use withStyle instead of withStyleLegacy
  • check if the v2 component uses all the tokens

see this link to see the rework: https://instructure.design/pr-preview/pr-2461/v11_7/Select

@ToMESSKa ToMESSKa self-assigned this Mar 17, 2026
Comment on lines 73 to +74
background: componentTheme.selectedHighlightedBackground,
color: componentTheme.highlightedLabelColor
color: componentTheme.selectedLabelColor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked in the two old canvas themes, but in the new light theme, the label would be black on a dark background (bad visibility) and in the new dark theme it would be white on a white background (bad visibilty). So I changed this. You can check this on the first example of in Select.

@github-actions
Copy link

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2465/

Built to branch gh-pages at 2026-03-17 14:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa requested review from balzss, hajnaldo and matyasf March 17, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant