Conversation
|
balzss
force-pushed
the
fix/icon-button-sizes
branch
from
303ccef to
5a0c82b
Compare
matyasf
approved these changes
Mar 18, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
looks and works good! I could not test it with DateInput2, since that is not merged yet
balzss
force-pushed
the
fix/icon-button-sizes
branch
from
5a0c82b to
885329f
Compare
joyenjoyer
approved these changes
Mar 18, 2026
Contributor
joyenjoyer
left a comment
joyenjoyer
left a comment
There was a problem hiding this comment.
I am happy that these ugly hacks got removed, code looks good
balzss
force-pushed
the
fix/icon-button-sizes
branch
from
885329f to
639abaa
Compare
… simplify TextInput afterElement Add condensedSmall and condensedMedium size options to IconButton, matching Button's existing condensed size support. These are intended for use inside compact layouts like TextInput. Remove temporary workarounds from TextInput that were needed to make the old IconButton work inside the afterElement slot: - Remove adjustAfterElementHeight DOM hack - Remove sizeVariants spread on afterElement container - Remove afterElementHasWidth state machinery - Simplify afterElement to a basic flex container with padding Update documentation examples in both IconButton and TextInput READMEs with a password visibility toggle use case and current icon names.
balzss
force-pushed
the
fix/icon-button-sizes
branch
from
639abaa to
0fd9e33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add condensedSmall and condensedMedium size options to IconButton, matching Button's existing condensed size support. These are intended for use inside compact layouts like TextInput.
Remove temporary workarounds from TextInput that were needed to make the old IconButton work inside the afterElement slot:
Update documentation examples in both IconButton and TextInput READMEs with a password visibility toggle use case and current icon names.