G-UTILS-GPROFILER REWORK (1): Add original files#263
Open
granulatedekel wants to merge 2 commits intomasterfrom
Open
G-UTILS-GPROFILER REWORK (1): Add original files#263granulatedekel wants to merge 2 commits intomasterfrom
granulatedekel wants to merge 2 commits intomasterfrom
Conversation
granulatedekel
changed the title
granulatedekel
changed the title
This was referenced Sep 23, 2024
granulatedekel
added
the
g-utils-gprofiler-rework
| return wrapper | ||
|
|
||
|
|
||
| def start_process( |
Contributor
There was a problem hiding this comment.
a reminder to update this function before merging
Contributor
|
@granulatedekel We should refrain from any mention of |
roi-granulate
suggested changes
Oct 7, 2024
Comment on lines
+1
to
+109
| # | ||
| # Copyright (C) 2022 Intel Corporation | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| import signal | ||
| import subprocess | ||
| from typing import List, Union | ||
|
|
||
|
|
||
| class PerfNoSupportedEvent(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class StopEventSetException(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class ProcessStoppedException(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class CalledProcessError(subprocess.CalledProcessError): | ||
| # Enough characters for 200 long lines | ||
| MAX_STDIO_LENGTH = 120 * 200 | ||
|
|
||
| def __init__( | ||
| self, | ||
| returncode: int, | ||
| cmd: Union[str, List[str]], | ||
| output: str, | ||
| stderr: str, | ||
| ): | ||
| assert isinstance(returncode, int), returncode | ||
| assert isinstance(cmd, str) or all(isinstance(s, str) for s in cmd), cmd | ||
| assert output is None or isinstance(output, str), output | ||
| assert stderr is None or isinstance(stderr, str), stderr | ||
| super().__init__(returncode, cmd, output, stderr) | ||
|
|
||
| def _truncate_stdio(self, stdio: str) -> str: | ||
| if len(stdio) > self.MAX_STDIO_LENGTH: | ||
| stdio = stdio[: self.MAX_STDIO_LENGTH - 3] + "..." | ||
| return stdio | ||
|
|
||
| def __str__(self) -> str: | ||
| if self.returncode and self.returncode < 0: | ||
| try: | ||
| base = f"Command {self.cmd!r} died with {signal.Signals(-self.returncode)!r}." | ||
| except ValueError: | ||
| base = f"Command {self.cmd!r} died with unknown signal {-self.returncode}." | ||
| else: | ||
| base = f"Command {self.cmd!r} returned non-zero exit status {self.returncode}." | ||
| return f"{base}\nstdout: {self._truncate_stdio(self.stdout)}\nstderr: {self._truncate_stdio(self.stderr)}" | ||
|
|
||
|
|
||
| class CalledProcessTimeoutError(CalledProcessError): | ||
| def __init__( | ||
| self, | ||
| timeout: float, | ||
| returncode: int, | ||
| cmd: Union[str, List[str]], | ||
| output: str, | ||
| stderr: str, | ||
| ): | ||
| super().__init__(returncode, cmd, output, stderr) | ||
| self.timeout = timeout | ||
|
|
||
| def __str__(self) -> str: | ||
| return f"Timed out after {self.timeout} seconds\n" + super().__str__() | ||
|
|
||
|
|
||
| class ProgramMissingException(Exception): | ||
| def __init__(self, program: str): | ||
| super().__init__(f"The program {program!r} is missing! Please install it") | ||
|
|
||
|
|
||
| class APIError(Exception): | ||
| def __init__(self, message: str, full_data: dict = None): | ||
| self.message = message | ||
| self.full_data = full_data | ||
|
|
||
| def __str__(self) -> str: | ||
| return self.message | ||
|
|
||
|
|
||
| class ThreadStopTimeoutError(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class SystemProfilerStartFailure(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class NoProfilersEnabledError(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class NoRwExecDirectoryFoundError(Exception): | ||
| pass |
Contributor
There was a problem hiding this comment.
I'll comment here because there's no changes in this file in the other PR.
note two things:
- iiuc, we don't need all the exceptions here (we won't utilize
PerfNoSupportedEventfor example, or am I wrong?) - we have
exceptions.pyingranulate-utilshere, we can copy those exceptions to there. of course - this should be taken care of in a different PR (G-UTILS-GPROFILER REWORK (2): Rework complex files #261 or a new one).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the G-UTILS-GPROFILER REWORK saga - which aims to move away shared code from gprofiler to the g-utils project:
#263 #261 intel/gprofiler#925 intel/gprofiler#926 intel/gprofiler#926
This PR is responsible for simply adding the files from gprofiler as-is (besides import changes), however it's broken as not all dependencies are added - those altered files will be handled in the subsequent PR