Open
Conversation
Use CMAKE_CONFIGURATION_TYPES converted to upper case when deducing build type dependent vars
afoxman
added a commit
to afoxman/hyperscan
that referenced
this pull request
Dec 27, 2023
GerHobbelt
pushed a commit
to GerHobbelt/hyperscan
that referenced
this pull request
Aug 31, 2025
Add CMake options for more build granularity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_BUILD_TYPEto upper case in-placeadd_directory(), case mismatch may occur for different references to the same internal targetsCMAKE_CONFIGURATION_TYPESconverted to upper case when deducing build type dependent varsCMAKE_C_FLAGS_RelWithDebInfois not the same asCMAKE_C_FLAGS_RELWITHDEBINFO, so addressed that too here