This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Hungarian notation string strError to string Error #390
Open
SnrNotHere16 wants to merge 1 commit intointel:masterfrom
Open
Hungarian notation string strError to string Error #390SnrNotHere16 wants to merge 1 commit intointel:masterfrom
SnrNotHere16 wants to merge 1 commit intointel:masterfrom
Conversation
This is my attempt to resolve the Remove Hungarian Notation issue. I changed the identifier of variable string strError to string Error. I also changed all the instances of strError to Error. Thank you.
Current coverage is 72.29% (diff: 20.00%)@@ master #390 diff @@
==========================================
Files 214 214
Lines 6674 6674
Methods 1447 1447
Messages 0 0
Branches 845 845
==========================================
Hits 4825 4825
Misses 1382 1382
Partials 467 467
|
Contributor
|
Hi, @SnrNotHere16. Thanks for tackling this issue. Our coding style uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to resolve the Remove Hungarian Notation issue. I changed the identifier of variable string strError to string Error. I also changed all the instances of strError to Error.
@@ master #390 diff @@ ========================================== Files 214 214 Lines 6674 6674 Methods 1447 1447 Messages 0 0 Branches 845 845 ========================================== Hits 4825 4825 Misses 1382 1382 Partials 467 467Our coding style uses
camelCasefor variables and only usesUpperCamelCasefor type names. It means thatstrErrorshould becomeerror. Also, it seems that you only updatedremote-process/main.cpp; is that intended?