Skip to content

Fix - Multiple page request at once#3492

Closed
IshaanXCoder wants to merge 2 commits intointelowlproject:developfrom
IshaanXCoder:feature/loading-multiple-pages
Closed

Fix - Multiple page request at once#3492
IshaanXCoder wants to merge 2 commits intointelowlproject:developfrom
IshaanXCoder:feature/loading-multiple-pages

Conversation

@IshaanXCoder
Copy link
Copy Markdown
Contributor

This PR addresses the first issue mentioned in #2764

Issue - The Frontend GUI loads all the pages at once instead of the first one only and the other ones when requested. That poses several problems while doing some particular researches. It is enough to trigger a single {4,5}xx error and the GUI does not react good (either provides no results or it completely breaks)

Description

All the pages (analysers, connectors etc) were loading all at once. Now, we only that particualr data is fetched which we can see in the GUI.

Type of change

  • New feature (non-breaking change which adds functionality).

Video

Screen.Recording.2026-03-17.at.1.57.13.PM.mov

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • Linters (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.

Copilot AI review requested due to automatic review settings March 17, 2026 10:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the frontend plugin configuration loading strategy to avoid prefetching all plugin categories up-front, and instead trigger fetching when specific plugin pages (Analyzers/Connectors/etc.) are visited.

Changes:

  • Removed plugin configuration store hydration from the global withAuth wrapper.
  • Initialized plugin store loading flags to false and added per-plugin-table lazy fetch on mount.
  • Updated a plugins table actions test to allow mocking usePluginConfigurationStore for loading scenarios.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
frontend/src/wrappers/withAuth.jsx Stops prefetching plugin configuration on authentication.
frontend/src/stores/usePluginConfigurationStore.jsx Changes initial loading flags to false (affects how/when data is fetched).
frontend/src/components/plugins/tables/Analyzers.jsx Adds mount-time fetch of analyzers configuration.
frontend/src/components/plugins/tables/Connectors.jsx Adds mount-time fetch of connectors configuration.
frontend/src/components/plugins/tables/Ingestors.jsx Adds mount-time fetch of ingestors configuration.
frontend/src/components/plugins/tables/Pivots.jsx Adds mount-time fetch of pivots configuration.
frontend/src/components/plugins/tables/Playbooks.jsx Adds mount-time fetch of playbooks configuration.
frontend/src/components/plugins/tables/Visualizers.jsx Adds mount-time fetch of visualizers configuration.
frontend/tests/components/plugins/tables/pluginActionsButtons.test.jsx Mocks usePluginConfigurationStore to test a playbooks edit loading case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/components/plugins/tables/Connectors.jsx Outdated
Comment thread frontend/src/components/plugins/tables/Ingestors.jsx Outdated
Comment thread frontend/src/components/plugins/tables/Pivots.jsx Outdated
Comment thread frontend/src/components/plugins/tables/Playbooks.jsx Outdated
Comment thread frontend/src/components/plugins/tables/Visualizers.jsx Outdated
Comment thread frontend/src/wrappers/withAuth.jsx
Comment thread frontend/src/stores/usePluginConfigurationStore.jsx
Comment thread frontend/src/components/plugins/tables/Analyzers.jsx Outdated
@IshaanXCoder IshaanXCoder mentioned this pull request Mar 17, 2026
17 tasks
@IshaanXCoder
Copy link
Copy Markdown
Contributor Author

hey @mlodic i implemented pagination loading on Analyzers page, but there's an issue. suppose if some analyzer is on page 37 (loads in the 4th batch of fetching)
considering the case we're on page 1 and we've not loaded 37th page yet, the search keyword feature wont work.
can fix this by server side rendering but this is over-engineering. i think we should continue with the current implementation upto the above 2 commits. what do you say?

@mlodic
Copy link
Copy Markdown
Member

mlodic commented Mar 24, 2026

yep thanks for exploring this further and raising the issue

@IshaanXCoder
Copy link
Copy Markdown
Contributor Author

np :)

@mlodic mlodic closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants