Fix - Multiple page request at once#3492
Fix - Multiple page request at once#3492IshaanXCoder wants to merge 2 commits intointelowlproject:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR changes the frontend plugin configuration loading strategy to avoid prefetching all plugin categories up-front, and instead trigger fetching when specific plugin pages (Analyzers/Connectors/etc.) are visited.
Changes:
- Removed plugin configuration store hydration from the global
withAuthwrapper. - Initialized plugin store loading flags to
falseand added per-plugin-table lazy fetch on mount. - Updated a plugins table actions test to allow mocking
usePluginConfigurationStorefor loading scenarios.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/wrappers/withAuth.jsx | Stops prefetching plugin configuration on authentication. |
| frontend/src/stores/usePluginConfigurationStore.jsx | Changes initial loading flags to false (affects how/when data is fetched). |
| frontend/src/components/plugins/tables/Analyzers.jsx | Adds mount-time fetch of analyzers configuration. |
| frontend/src/components/plugins/tables/Connectors.jsx | Adds mount-time fetch of connectors configuration. |
| frontend/src/components/plugins/tables/Ingestors.jsx | Adds mount-time fetch of ingestors configuration. |
| frontend/src/components/plugins/tables/Pivots.jsx | Adds mount-time fetch of pivots configuration. |
| frontend/src/components/plugins/tables/Playbooks.jsx | Adds mount-time fetch of playbooks configuration. |
| frontend/src/components/plugins/tables/Visualizers.jsx | Adds mount-time fetch of visualizers configuration. |
| frontend/tests/components/plugins/tables/pluginActionsButtons.test.jsx | Mocks usePluginConfigurationStore to test a playbooks edit loading case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hey @mlodic i implemented pagination loading on Analyzers page, but there's an issue. suppose if some analyzer is on page 37 (loads in the 4th batch of fetching) |
|
yep thanks for exploring this further and raising the issue |
|
np :) |
This PR addresses the first issue mentioned in #2764
Description
All the pages (analysers, connectors etc) were loading all at once. Now, we only that particualr data is fetched which we can see in the GUI.
Type of change
Video
Screen.Recording.2026-03-17.at.1.57.13.PM.mov
Checklist
developRuff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.