Adding fix for the missing nil checks. #356
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahmdrza
reviewed
Jan 19, 2026
| resolver:(RCTPromiseResolveBlock)resolve | ||
| rejecter:(RCTPromiseRejectBlock)reject) { | ||
| // Validate content dictionary | ||
| if (!content || ![content isKindOfClass:[NSDictionary class]]) { |
There was a problem hiding this comment.
if content type changes in ios and android, we will have to update here as well. What if we move validation in android and ios sdks and make sure proper error is returned via RN as well?
| NSString *contentType = content[@"type"]; | ||
|
|
||
| // Add nil check before calling methods | ||
| if (!contentType || ![contentType isKindOfClass:[NSString class]]) { |
There was a problem hiding this comment.
same comment as above and for others validations
| } | ||
| }; | ||
|
|
||
| const ensureString = (value: string, fallback = '') => |
There was a problem hiding this comment.
we can bypass this validation by passing wrong value as fallback param, for example, ensureString(1, 1) would return 1, even though its not a string. I think we should just return error that if value is not string, return error
| const ensureString = (value: string, fallback = '') => | ||
| typeof value === 'string' ? value : fallback; | ||
|
|
||
| const ensureNumber = (value: number, fallback = 0) => |
There was a problem hiding this comment.
same comment as above and in other methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding defensive checks for the missing nil checks on the react native code base.