Skip to content

2d bug fix#227

Merged
zfergus merged 4 commits into
ipc-sim:mainfrom
udaykusupati:main
Apr 24, 2026
Merged

2d bug fix#227
zfergus merged 4 commits into
ipc-sim:mainfrom
udaykusupati:main

Conversation

@udaykusupati
Copy link
Copy Markdown
Contributor

@udaykusupati udaykusupati commented Apr 22, 2026

Description

2D GCP has a bug due to Edge2's active check being trivially loose.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test: Visualized gradients for a simple 2D example where dhat is greater than the object thickness. Spurious exterior gradients appear without the bug fix.

Checklist

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.85%. Comparing base (6e60a2d) to head (7b1e5c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         160      160           
  Lines       16661    16664    +3     
  Branches      946      947    +1     
=======================================
+ Hits        15970    15973    +3     
  Misses        691      691           
Flag Coverage Δ
unittests 95.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@udaykusupati
Copy link
Copy Markdown
Contributor Author

Added a new commit that should pass the tests for non-orientable case too

@zfergus zfergus merged commit 1db208d into ipc-sim:main Apr 24, 2026
17 of 18 checks passed
@zfergus zfergus added this to the v1.6.0 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants