Add env var to disable SIMD in setup.py#231
Merged
Merged
Conversation
- Add `IPCTK_WITH_SIMD` environment variable to control SIMD support in Python builds - Reformat `setup.py` to match standard Python style guidelines
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a build-time switch to disable SIMD in the Python packaging flow (to avoid platform-specific build failures) and updates formatting in the Python build script.
Changes:
- Add
IPCTK_WITH_SIMDenvironment variable support insetup.pyand forward it to CMake as-DIPC_TOOLKIT_WITH_SIMD=.... - Disable SIMD in the GitHub Actions Python workflow by setting
IPCTK_WITH_SIMD=0duringpip install. - Reformat portions of
setup.pyfor readability/consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Adds env-var-controlled SIMD toggle passed through to CMake; includes formatting adjustments. |
| .github/workflows/python.yml | Forces SIMD off in CI during Python package build/install step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Support "off", "false", and "no" values for IPCTK_WITH_SIMD in setup.py - Re-enable SIMD for macOS and Windows Python CI builds
- Document the `IPCTK_WITH_SIMD` environment variable for `pip install` - List accepted falsy values for disabling SIMD optimizations - Add a note on forcing a source build from PyPI to apply the flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IPCTK_WITH_SIMDenvironment variable to control SIMD support in Python buildssetup.pyto match standard Python style guidelinesType of change