Skip to content

fix(blockstore): don't activate bloom cache if build incomplete#1183

Open
guillaumemichel wants to merge 3 commits into
mainfrom
fix/bloom-incomplete-build
Open

fix(blockstore): don't activate bloom cache if build incomplete#1183
guillaumemichel wants to merge 3 commits into
mainfrom
fix/bloom-incomplete-build

Merge branch 'main' into fix/bloom-incomplete-build

bbf07ab
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 3, 2026 in 0s

63.75% (+0.06%) compared to 8a6d1d2

View this Pull Request on Codecov

63.75% (+0.06%) compared to 8a6d1d2

Details

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.75%. Comparing base (8a6d1d2) to head (bbf07ab).

Files with missing lines Patch % Lines
blockstore/blockstore.go 93.75% 1 Missing ⚠️
blockstore/bloom_cache.go 85.71% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   63.69%   63.75%   +0.06%     
==========================================
  Files         269      269              
  Lines       27003    27027      +24     
==========================================
+ Hits        17200    17232      +32     
+ Misses       8092     8081      -11     
- Partials     1711     1714       +3     
Files with missing lines Coverage Δ
blockstore/idstore.go 68.25% <100.00%> (+1.04%) ⬆️
blockstore/twoqueue_cache.go 72.46% <100.00%> (-2.18%) ⬇️
blockstore/validating_blockstore.go 66.66% <100.00%> (+6.66%) ⬆️
blockstore/blockstore.go 56.02% <93.75%> (+9.15%) ⬆️
blockstore/bloom_cache.go 69.60% <85.71%> (+6.26%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.