Draft
Improve Change Pal dialog layout and replace compatibility checkbox with protocol selector#730
Conversation
Copilot
AI
changed the title
[WIP] Fix GUI alignment and update compatible to protocol
Improve Change Pal dialog layout and replace compatibility checkbox with protocol selector
Jul 24, 2026
Member
|
@copilot window stuck after click "OK" in the popup "Change Pal's Information" |
lidaobing
requested changes
Jul 24, 2026
| g_object_unref(pixbuf); | ||
| if (active >= 0) { | ||
| snprintf(path, MAX_PATHLEN, "%d", active); | ||
| gtk_tree_model_get_iter_from_string(model, &iter, path); |
Member
There was a problem hiding this comment.
this part is weird, you should change the Pal model, and the model change trigger the UImodel change
|
❌ The last analysis has failed. |
Contributor
Author
Member
still stuck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “Change Pal’s Information” dialog had inconsistent label/field alignment, and its last control exposed protocol behavior as a single compatibility checkbox. This updates the dialog to use a clearer aligned layout and surfaces protocol selection explicitly as
AUTO,IPMSG, orIPTUX.Dialog layout
Protocol selection
Protocolcombo box.AUTO: preserve detected/default compatibility behaviorIPMSG: force IP Messenger-compatible behaviorIPTUX: force iptux protocol behaviorModel behavior
PalInfoinstead of overloading a boolean UI control.Dialog robustness
Example of the new protocol model behavior: