Remove dead json_clean / jsonutil module#1503
Draft
erikgaas wants to merge 1 commit intoipython:mainfrom
Draft
Conversation
erikgaas
commented
Mar 6, 2026
| # Copyright (c) IPython Development Team. | ||
| # Distributed under the terms of the Modified BSD License. | ||
|
|
||
| import math |
Member
|
I like that ! Apparently there are similar utils in jupyter_client (and the one from jupyter_client is used in jupyter_server). Those should also likely go through a cycle of deprecation/removal ! Thanks, (rebasing to try to get tests to pass) |
Member
|
ipyparallel will need fixeed it imports json clean from ipykernel. (changing to draft, if you or someone else want to send a fix to ipyparallel) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some preliminary exploration trying to get more up to speed with the codebase.
json_clean()has been a no-op since jupyter_client >= 7 (released 2021). Since ipykernel now requiresjupyter_client>=8.8.0, this code can never execute.Changes
ipykernel/jsonutil.pyentirelyjson_clean()call sites inkernelbase.py(7 calls + import)tests/test_jsonutil.py(all tests were alreadyskipIf(jupyter_client >= 7))No behavioral change — every removed
json_clean()call was returning its input unchanged.