Deduplicate awaitable check in request handlers#1507
Closed
erikgaas wants to merge 2 commits intoipython:mainfrom
Closed
Deduplicate awaitable check in request handlers#1507erikgaas wants to merge 2 commits intoipython:mainfrom
erikgaas wants to merge 2 commits intoipython:mainfrom
Conversation
Extract repeated 7-line pattern into _await_result() helper method. Each request handler (do_execute, do_complete, do_inspect, do_history, do_shutdown, do_is_complete, do_debug_request) had an identical block checking if the result was awaitable and warning if not. Reduces ~42 lines of duplicated code to 7 one-line call sites.
for more information, see https://pre-commit.ci
Member
|
Duplication in this case is I think better, because when we remove the pending deprecation branches we can do an a case by cases basis. Not everything need to always be DRY. Plus the function _await_result, does not make it clear to the reader that some path are deprecated. It's a personal decision and thanks you for suggesting it though I don't belive we want to go that route for this particular case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every request handler in
kernelbase.pyhad the same 7-line pattern checking if thedo_*method returned an awaitable and warning if not. This PR extracts that into a single_await_result()helper.Changes
_await_result(result, func_name)method toKernelclass