Fix ENOTSOCK traceback when iopub socket closes during shutdown#1518
Open
Carreau wants to merge 1 commit intoipython:mainfrom
Open
Fix ENOTSOCK traceback when iopub socket closes during shutdown#1518Carreau wants to merge 1 commit intoipython:mainfrom
Carreau wants to merge 1 commit intoipython:mainfrom
Conversation
Likely fix nbclient downstream test. After a control handler completes, process_control unconditionally publishes an "idle" status. During shutdown this races with IOPubThread.close(): the IO thread has been joined, so _really_send runs on the caller's thread while close() runs on another, and the `if self.closed` check is TOCTOU with the subsequent send_multipart. Catch the resulting ZMQError(ENOTSOCK) (and AttributeError if self.socket has flipped to None) in _really_send and log at debug level instead of letting tornado log an uncaught-callback traceback.
minrk
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely fix nbclient downstream test.
After a control handler completes, process_control unconditionally publishes an "idle" status. During shutdown this races with IOPubThread.close(): the IO thread has been joined, so _really_send runs on the caller's thread while close() runs on another, and the
if self.closedcheck is TOCTOU with the subsequent send_multipart.Catch the resulting ZMQError(ENOTSOCK) (and AttributeError if self.socket has flipped to None) in _really_send and log at debug level instead of letting tornado log an uncaught-callback traceback.