[Codegen] Add ConvertSRefToMemRefPass #22916
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ConvertSRefToMemRefPass which converts pcf.sref types to their concrete memref equivalents. The pass performs layout propagation analysis using DFX to determine the most specific memref layout for each sref value based on how it's produced and used. It then converts: - pcf.alloc to memref.alloc - pcf.write_slice to memref.subview + store operations - pcf.read_slice to memref.subview + load operations - pcf.get_memref to memref.subview with layout casts - pcf.generic/loop result types from tensor to memref Function signatures are updated to use memref types instead of sref types, with proper layout inference from call sites. Also adds loadSRefLoweringDependentDialects to PCFConversionDialectInterface, allowing external dialects to register dependent dialects needed during sref conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ConvertSRefToMemRefPass which converts pcf.sref types to memrefs.
The pass performs layout propagation analysis using DFX to determine the most specific memref layout for each sref value based on how it's produced and used. It then converts:
Function signatures are updated to use memref types instead of sref types, with proper layout inference from call sites.
Also adds loadSRefLoweringDependentDialects to
PCFConversionDialectInterface, allowing external dialects to register dependent dialects needed during sref conversion.