Add oracle prompts to moves that don't roll on stats or progress #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no-roll moves, i.e. moves that neither roll on a stat nor a progress track, contain references to oracles, prompt for the oracle and add its result to the resulting move node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few moves that don't roll on stats or a progress track, but that have an oracle attached to it, e.g.
Currently, using the "Make a move" command or the "Make this move with prompts" button in the Moves sidebar creates just an empty move node for those. Thought it would be nice to have the oracle involved directly with the move, so this change here adds a prompt to roll on the attached oracle(s) and add the result to the move nodes, turning it from
to
The prompt for "Ask the Oracle" looks for example like this then:
which then triggers the matching oracle popup - or not, if "Skip rolling on oracle" is selected, in which case an empty move node is added, just like before.
Note that this only affects moves that don't have any stats or progress track attached to, so "Endure Stress" / "Endure Harm" as example, which lets you roll on stats but also roll on an oracle to interpret the outcome, won't be affected by this change.