Skip to content

Conversation

@felix-kaestner
Copy link
Contributor

The default values are taken from the DME reference. See https://pubhub.devnetcloud.com/media/dme-docs-10-4-3/docs/System/vpc:Dom/

@felix-kaestner felix-kaestner requested a review from a team as a code owner January 19, 2026 18:49
@felix-kaestner felix-kaestner force-pushed the nxos-feature-activation branch from 9c86dea to 47ac8d7 Compare January 19, 2026 19:19
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jan 20, 2026
@hardikdr hardikdr added this to Roadmap Jan 20, 2026
@felix-kaestner felix-kaestner force-pushed the nxos-feature-activation branch 3 times, most recently from bfe6337 to 16a3a8a Compare January 20, 2026 09:57
Base automatically changed from nxos-feature-activation to main January 20, 2026 13:37
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 11.28% (+0.03%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/vpcdomain_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.07% (+0.00%) 1433 (-5) 1 1432 (-5) 👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/vpc.go 12.00% (ø) 25 3 22

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/vpc_test.go

@felix-kaestner felix-kaestner merged commit 8d57167 into main Jan 20, 2026
10 checks passed
@felix-kaestner felix-kaestner deleted the vpc-defaults branch January 20, 2026 14:07
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants