Use YEAR in hack/boilerplate.go.txt as a literal for the current year#272
Open
felix-kaestner wants to merge 1 commit intomainfrom
Open
Use YEAR in hack/boilerplate.go.txt as a literal for the current year#272felix-kaestner wants to merge 1 commit intomainfrom
hack/boilerplate.go.txt as a literal for the current year#272felix-kaestner wants to merge 1 commit intomainfrom
Conversation
felix-kaestner
force-pushed
the
license-header
branch
from
7d166dd to
8fb72a3
Compare
hardikdr
added
the
area/switch-automation
felix-kaestner
force-pushed
the
license-header
branch
from
8fb72a3 to
f920255
Compare
felix-kaestner
force-pushed
the
license-header
branch
2 times, most recently
from
69f8246 to
b7fc096
Compare
felix-kaestner
force-pushed
the
license-header
branch
from
b7fc096 to
442cd01
Compare
The YEAR string in the boilerplate header file will be replaced by controller-gen[^1] and kubebuilder[^2]. This change also requires to define a YEAR variable in the Makefile (holding the current year) which is passed as year=$(YEAR) to the controller-gen crd generation. The applyconfiguration generator of controller-gen handles this substitution automatically by using kubernetes/gengo[^3] and does not need the explicit parameter. This change is possible through a recent addition in go-makefile-maker[^4]. [^1]: kubernetes-sigs/controller-tools@54a2e9f [^2]: kubernetes-sigs/kubebuilder@890b118 [^3]: https://github.com/kubernetes/gengo/blob/5ee0d033ba5bcb073f0e69c32057520b82d75ccb/v2/execute.go#L59 [^4]: sapcc/go-makefile-maker#477 Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
license-header
branch
from
b1d259d to
f13539b
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The YEAR string in the boilerplate header file will be replaced by
controller-gen1 and kubebuilder2.
This change also requires to define a YEAR variable in the Makefile
(holding the current year) which is passed as year=$(YEAR) to the
controller-gen crd generation. The applyconfiguration generator of
controller-gen handles this substitution automatically by using
kubernetes/gengo3 and does not need the explicit parameter.
This change is possible through a recent addition in
go-makefile-maker4.
Footnotes
https://github.com/kubernetes-sigs/controller-tools/commit/54a2e9f1ac63927545179bb8cd82aff15540a418 ↩
https://github.com/kubernetes-sigs/kubebuilder/commit/890b11808e0d932de4dcc92a742e5b7f0c532298 ↩
https://github.com/kubernetes/gengo/blob/5ee0d033ba5bcb073f0e69c32057520b82d75ccb/v2/execute.go#L59 ↩
https://github.com/sapcc/go-makefile-maker/pull/477 ↩