Upgrade controller-runtime to v0.24.0 and k8s.io/* to v1.36#339
Draft
felix-kaestner wants to merge 2 commits intomainfrom
Draft
Upgrade controller-runtime to v0.24.0 and k8s.io/* to v1.36#339felix-kaestner wants to merge 2 commits intomainfrom
felix-kaestner wants to merge 2 commits intomainfrom
Conversation
See: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.24.0 Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
ce05cdd to
218f95c
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
controller-runtime v0.24.0 deprecated the scheme.Builder helper. Replace it with k8s.io/apimachinery/pkg/runtime.NewSchemeBuilder and register types via s.AddKnownTypes following upstream patterns. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
218f95c to
832dff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.24.0