Fix bug with repeated calls to form_pattern#274
Merged
Conversation
rad-eng-59
reviewed
May 24, 2026
rad-eng-59
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the fix.
I thought we could fix the problem earlier in case somebody add another line in the future and make the same mistake I did.
Btw, that makes me realize that elements of a numpy-array type member of so-called immutable frozen dataclass is still mutable! Very annoying.
hfattahi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to optimize the antenna pattern weights and thought I was going crazy because I'd get different patterns every time I called
AntennaPattern.form_pattern. It turns out #231 introduced a bug where the receive pattern weights mutate the stored LNA/caltone ratio on every call.In focus.py we only call
form_patterntwice on each instance, once for the science data and then again for the noise data. So in production the image is fine but the noise equivalent backscatter is calculating the wrong RX pattern whenever the weights aren't unity.