6267: Added GitHub Action for checking images can be pulled #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
approved these changes
Jan 6, 2026
| - uses: actions/checkout@v5 | ||
| - name: Check that docker images can be pulled | ||
| run: | | ||
| COMPOSE_PROFILES='*' docker compose pull |
Contributor
There was a problem hiding this comment.
🎉 (for remembering to include all profiles)
rimi-itk
reviewed
Jan 6, 2026
Comment on lines
+11
to
+12
| on: | ||
| pull_request: |
Contributor
There was a problem hiding this comment.
It may be worth considering doing this on a schedule as well, cf. https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule.
Contributor
Author
|
As per discussion in Teams this is deemed as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/6267
We recently encountered an issue with an image being removed, c.f itk-dev/selvbetjening.aarhuskommune.dk#459 and itk-dev/deltag.aarhus.dk#581.
The added action simply checks that images can be pulled across any compose profile. Should it check across all profiles? Some profiles are simply meant for local development in very specific cases, i.e. mock oidc.
Note
The Drupal
siteactionsinstallandupdatetechnically already checks this viadocker compose pullcalls, but a separate check focussing on this seems fitting to me.