Skip to content

Prefilter VCS permalink lines#2253

Merged
j178 merged 2 commits into
masterfrom
perf-vcs-prefilter
Jun 26, 2026
Merged

Prefilter VCS permalink lines#2253
j178 merged 2 commits into
masterfrom
perf-vcs-prefilter

Conversation

@j178

@j178 j178 commented Jun 26, 2026

Copy link
Copy Markdown
Owner
❯ hyperfine --warmup 5 --runs 30  "prek run check-vcs-permalinks --all-files" "./target/profiling/prek run check-vcs-permalinks --all-files" -i                                                                                                                                                                           
Benchmark 1: prek run check-vcs-permalinks --all-files
  Time (mean ± σ):     107.5 ms ±   8.3 ms    [User: 81.3 ms, System: 29.2 ms]
  Range (min … max):    97.6 ms … 134.6 ms    30 runs
 
  Warning: Ignoring non-zero exit code.
 
Benchmark 2: ./target/profiling/prek run check-vcs-permalinks --all-files
  Time (mean ± σ):      39.3 ms ±   1.1 ms    [User: 20.4 ms, System: 27.5 ms]
  Range (min … max):    36.9 ms …  41.8 ms    30 runs
 
  Warning: Ignoring non-zero exit code.
 
Summary
  ./target/profiling/prek run check-vcs-permalinks --all-files ran
    2.74 ± 0.23 times faster than prek run check-vcs-permalinks --all-files

Copilot AI review requested due to automatic review settings June 26, 2026 10:46
@j178 j178 added the performance Performance improvements label Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.75%. Comparing base (a77fdad) to head (ebf4456).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
+ Coverage   92.73%   92.75%   +0.01%     
==========================================
  Files         127      127              
  Lines       27486    27518      +32     
==========================================
+ Hits        25489    25523      +34     
+ Misses       1997     1995       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e64c23d35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/prek/src/hooks/pre_commit_hooks/check_vcs_permalinks.rs
Comment thread crates/prek/src/hooks/pre_commit_hooks/check_vcs_permalinks.rs Outdated
@prek-ci-bot

prek-ci-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

Binary size change: +1.12% (26.7 MiB → 27.0 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.4%   0.7% 101.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  96.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  64.9KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.8KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.2%   0.3%  43.7KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  35.3KiB              prek prek::hooks::meta_hooks::check_hooks_apply::{{closure}}
 0.1%   0.3%  34.5KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  32.8KiB              prek prek::archive::unpack::{{closure}}
 0.1%   0.2%  31.8KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  29.8KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::RemoteHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.1KiB              prek prek::languages::ruby::installer::RubyInstaller::install::{{closure}}
42.1%  86.1%  11.4MiB                   And 24886 smaller methods. Use -n N to show more.
48.8% 100.0%  13.2MiB                   .text section size, the file size is 27.0MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.4%   0.7%  96.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.2KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  64.7KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.8KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.8KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.2%   0.3%  44.1KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  34.3KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  32.8KiB              prek prek::archive::unpack::{{closure}}
 0.1%   0.2%  31.1KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  29.8KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.2KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::RemoteHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  26.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.1KiB              prek prek::languages::ruby::installer::RubyInstaller::install::{{closure}}
 0.1%   0.2%  24.0KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::LocalHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
42.0%  86.1%  11.2MiB                   And 24551 smaller methods. Use -n N to show more.
48.7% 100.0%  13.0MiB                   .text section size, the file size is 26.7MiB

@prek-ci-bot

prek-ci-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1018-azure
  • CPU: 4 cores
  • prek version: prek 0.4.5+26 (ead4265 2026-06-26)
  • Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.2 ± 0.2 2.0 3.7 1.04 ± 0.12
prek-head --version 2.1 ± 0.1 2.0 3.0 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.2 ± 3.1 8.6 40.2 1.01 ± 0.38
prek-head list 9.1 ± 1.4 8.6 22.8 1.00

prek validate-config .pre-commit-config.yaml

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base validate-config .pre-commit-config.yaml 3.0 ± 0.1 2.8 3.4 1.01 ± 0.05
prek-head validate-config .pre-commit-config.yaml 2.9 ± 0.1 2.8 3.1 1.00

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.4 ± 0.0 2.3 2.5 1.00
prek-head sample-config 2.4 ± 0.0 2.3 2.5 1.01 ± 0.03
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 72.0 ± 2.6 69.6 76.7 1.00
prek-head run --all-files 72.6 ± 2.2 70.0 75.8 1.01 ± 0.05

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 72.8 ± 2.4 68.1 76.5 1.00
prek-head run --all-files 73.3 ± 2.7 68.0 77.1 1.01 ± 0.05
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 73.2 ± 2.5 68.2 79.5 1.00 ± 0.05
prek-head run --all-files 73.1 ± 2.6 68.5 79.0 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 19.3 ± 0.4 18.9 20.4 1.00 ± 0.03
prek-head run trailing-whitespace --all-files 19.3 ± 0.4 18.6 19.9 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 24.5 ± 1.3 23.2 28.8 1.00
prek-head run end-of-file-fixer --all-files 25.3 ± 1.5 23.4 29.4 1.03 ± 0.08

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 7.4 ± 0.3 7.0 8.1 1.01 ± 0.05
prek-head run check-json --all-files 7.4 ± 0.3 7.0 8.0 1.00

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 7.2 ± 0.1 6.9 7.4 1.00 ± 0.03
prek-head run check-yaml --all-files 7.1 ± 0.1 6.9 7.5 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 7.5 ± 0.3 6.8 8.4 1.02 ± 0.06
prek-head run check-toml --all-files 7.3 ± 0.3 7.0 8.1 1.00

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 7.3 ± 0.2 6.9 7.7 1.00
prek-head run check-xml --all-files 7.4 ± 0.3 6.8 7.8 1.01 ± 0.05

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 12.9 ± 1.1 11.4 15.7 1.00
prek-head run detect-private-key --all-files 13.0 ± 1.0 11.3 14.9 1.01 ± 0.12

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 17.3 ± 0.8 16.1 18.9 1.00
prek-head run fix-byte-order-marker --all-files 17.4 ± 0.8 16.4 19.3 1.01 ± 0.06
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.3 ± 0.1 4.2 4.4 1.02 ± 0.03
prek-head install-hooks 4.2 ± 0.1 4.1 4.3 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.3 ± 0.1 4.2 4.3 1.00
prek-head install-hooks 4.4 ± 0.1 4.3 4.4 1.02 ± 0.02
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 37.5 ± 1.4 35.2 41.0 1.01 ± 0.05
prek-head run 37.0 ± 1.1 35.3 39.6 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 7.7 ± 0.1 7.5 7.9 1.00
prek-head run --files '*.json' 8.0 ± 0.2 7.7 8.3 1.04 ± 0.02
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 6.5 ± 0.1 6.4 6.6 1.00 ± 0.01
prek-head run --dry-run --all-files 6.5 ± 0.1 6.4 6.7 1.00
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 11.2 ± 0.6 10.0 11.8 1.10 ± 0.06
prek-head run check-hooks-apply --all-files 10.2 ± 0.1 10.0 10.4 1.00

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 10.1 ± 0.1 10.0 10.3 1.00
prek-head run check-useless-excludes --all-files 10.2 ± 0.1 10.0 10.6 1.01 ± 0.02

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 9.4 ± 0.1 9.3 9.5 1.00
prek-head run identity --all-files 9.6 ± 0.1 9.4 9.8 1.01 ± 0.01

@j178 j178 changed the title perf vcs prefilter Prefilter VCS permalink lines Jun 26, 2026
```
❯ hyperfine --warmup 5 --runs 30  "prek run check-vcs-permalinks --all-files" "./target/profiling/prek run check-vcs-permalinks --all-files" -i
Benchmark 1: prek run check-vcs-permalinks --all-files
  Time (mean ± σ):     107.5 ms ±   8.3 ms    [User: 81.3 ms, System: 29.2 ms]
  Range (min … max):    97.6 ms … 134.6 ms    30 runs

  Warning: Ignoring non-zero exit code.

Benchmark 2: ./target/profiling/prek run check-vcs-permalinks --all-files
  Time (mean ± σ):      39.3 ms ±   1.1 ms    [User: 20.4 ms, System: 27.5 ms]
  Range (min … max):    36.9 ms …  41.8 ms    30 runs

  Warning: Ignoring non-zero exit code.

Summary
  ./target/profiling/prek run check-vcs-permalinks --all-files ran
    2.74 ± 0.23 times faster than prek run check-vcs-permalinks --all-files
```
@j178 j178 force-pushed the perf-vcs-prefilter branch from 4e64c23 to ebf4456 Compare June 26, 2026 11:07
@j178 j178 merged commit a538d83 into master Jun 26, 2026
35 checks passed
@j178 j178 deleted the perf-vcs-prefilter branch June 26, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants