Skip to content

Stop static linking liblzma#2254

Closed
j178 wants to merge 1 commit into
masterfrom
liblzma
Closed

Stop static linking liblzma#2254
j178 wants to merge 1 commit into
masterfrom
liblzma

Conversation

@j178

@j178 j178 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

No description provided.

@j178 j178 added the internal Internal changes label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.75%. Comparing base (a538d83) to head (7bf8aa6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2254   +/-   ##
=======================================
  Coverage   92.74%   92.75%           
=======================================
  Files         127      127           
  Lines       27518    27518           
=======================================
+ Hits        25522    25523    +1     
+ Misses       1996     1995    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prek-ci-bot

prek-ci-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

Binary size change: +0.00% (26.8 MiB → 26.8 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.4%   0.7%  96.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  66.2KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.8KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.1KiB              prek prek::cli::run::run::run::{{closure}}
 0.2%   0.3%  44.0KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.3%  34.3KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  32.8KiB              prek prek::archive::unpack::{{closure}}
 0.1%   0.2%  32.1KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  29.8KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.7KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::RemoteHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.1KiB              prek prek::languages::ruby::installer::RubyInstaller::install::{{closure}}
 0.1%   0.2%  24.1KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::LocalHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
42.0%  86.1%  11.2MiB                   And 24566 smaller methods. Use -n N to show more.
48.7% 100.0%  13.0MiB                   .text section size, the file size is 26.8MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.4%   0.7%  96.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  92.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  66.2KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.8KiB              prek prek::run::{{closure}}
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  44.1KiB              prek prek::cli::run::run::run::{{closure}}
 0.2%   0.3%  44.0KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.3%  34.3KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  32.8KiB              prek prek::archive::unpack::{{closure}}
 0.1%   0.2%  32.1KiB             prek? <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  29.8KiB     granit_parser granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.7KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::RemoteHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.1KiB              prek prek::languages::ruby::installer::RubyInstaller::install::{{closure}}
 0.1%   0.2%  24.1KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::LocalHook>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
42.0%  86.1%  11.2MiB                   And 24562 smaller methods. Use -n N to show more.
48.7% 100.0%  13.0MiB                   .text section size, the file size is 26.8MiB

@prek-ci-bot

prek-ci-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 1 regressions, 0 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1018-azure
  • CPU: 4 cores
  • prek version: prek 0.4.5+26 (82e1be7 2026-06-27)
  • Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.1 ± 0.1 2.0 2.5 1.00 ± 0.06
prek-head --version 2.1 ± 0.1 2.0 2.7 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 8.8 ± 0.2 8.6 9.9 1.00
prek-head list 8.8 ± 0.1 8.5 9.3 1.00 ± 0.02

prek validate-config .pre-commit-config.yaml

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base validate-config .pre-commit-config.yaml 2.9 ± 0.0 2.8 3.0 1.00 ± 0.03
prek-head validate-config .pre-commit-config.yaml 2.9 ± 0.1 2.8 3.1 1.00

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.4 ± 0.0 2.3 2.5 1.00
prek-head sample-config 2.4 ± 0.0 2.3 2.4 1.00 ± 0.02
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 73.4 ± 1.9 70.3 75.8 1.01 ± 0.05
prek-head run --all-files 72.3 ± 2.6 69.4 76.3 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 72.7 ± 2.5 68.6 76.0 1.00 ± 0.05
prek-head run --all-files 72.4 ± 2.6 68.0 78.0 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 72.9 ± 2.5 68.0 81.4 1.01 ± 0.05
prek-head run --all-files 72.4 ± 2.4 68.5 77.4 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 19.1 ± 0.2 18.6 19.7 1.01 ± 0.02
prek-head run trailing-whitespace --all-files 19.0 ± 0.3 18.5 19.7 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 24.5 ± 1.5 22.8 27.6 1.00
prek-head run end-of-file-fixer --all-files 25.0 ± 1.9 23.0 28.4 1.02 ± 0.10

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 7.2 ± 0.2 6.9 7.8 1.00
prek-head run check-json --all-files 7.3 ± 0.4 6.7 8.7 1.01 ± 0.06

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 7.1 ± 0.1 6.9 7.2 1.01 ± 0.02
prek-head run check-yaml --all-files 7.0 ± 0.1 6.8 7.2 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 7.3 ± 0.3 6.8 7.7 1.00
prek-head run check-toml --all-files 7.3 ± 0.4 6.6 8.2 1.01 ± 0.07

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 7.3 ± 0.3 6.6 8.0 1.01 ± 0.06
prek-head run check-xml --all-files 7.2 ± 0.2 6.9 7.8 1.00

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 13.1 ± 1.2 11.1 16.5 1.00
prek-head run detect-private-key --all-files 13.4 ± 1.0 11.6 15.5 1.03 ± 0.12

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 17.3 ± 0.8 16.0 18.9 1.00 ± 0.07
prek-head run fix-byte-order-marker --all-files 17.3 ± 1.0 16.0 20.7 1.00
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.2 ± 0.1 4.2 4.3 1.01 ± 0.02
prek-head install-hooks 4.2 ± 0.0 4.1 4.2 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.2 ± 0.0 4.2 4.3 1.00
prek-head install-hooks 4.3 ± 0.1 4.2 4.5 1.02 ± 0.03
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 36.5 ± 1.3 34.8 38.6 1.01 ± 0.04
prek-head run 36.2 ± 0.7 35.0 37.4 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 7.5 ± 0.1 7.4 7.7 1.01 ± 0.01
prek-head run --files '*.json' 7.5 ± 0.1 7.4 7.7 1.00
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 6.5 ± 0.1 6.4 6.6 1.00
prek-head run --dry-run --all-files 23.8 ± 56.9 6.3 250.3 3.68 ± 8.80

⚠️ Warning: Performance regression for prek run --dry-run --all-files (measures init overhead): 268.3600% slower

Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 11.2 ± 0.4 10.1 11.5 1.11 ± 0.04
prek-head run check-hooks-apply --all-files 10.1 ± 0.1 10.0 10.3 1.00

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 10.1 ± 0.2 9.9 10.7 1.01 ± 0.02
prek-head run check-useless-excludes --all-files 10.0 ± 0.1 9.9 10.2 1.00

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 9.4 ± 0.0 9.3 9.5 1.00 ± 0.01
prek-head run identity --all-files 9.4 ± 0.1 9.3 9.7 1.00

@j178 j178 closed this Jun 26, 2026
@j178 j178 deleted the liblzma branch June 27, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant