Improve subprocess error messages#2257
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2257 +/- ##
==========================================
+ Coverage 92.74% 92.92% +0.18%
==========================================
Files 127 127
Lines 27518 27583 +65
==========================================
+ Hits 25522 25632 +110
+ Misses 1996 1951 -45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8538d77f30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📦 Cargo Bloat ComparisonBinary size change: +0.00% (26.8 MiB → 26.8 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
1.8 ± 0.1 | 1.7 | 2.5 | 1.05 ± 0.08 |
prek-head --version |
1.7 ± 0.1 | 1.6 | 2.2 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
7.9 ± 0.1 | 7.6 | 8.5 | 1.02 ± 0.02 |
prek-head list |
7.8 ± 0.1 | 7.5 | 8.0 | 1.00 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
2.6 ± 0.1 | 2.5 | 3.1 | 1.04 ± 0.04 |
prek-head validate-config .pre-commit-config.yaml |
2.5 ± 0.1 | 2.4 | 2.7 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.1 ± 0.0 | 2.0 | 2.2 | 1.02 ± 0.03 |
prek-head sample-config |
2.0 ± 0.0 | 1.9 | 2.1 | 1.00 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
53.5 ± 1.6 | 50.9 | 56.7 | 1.01 ± 0.04 |
prek-head run --all-files |
52.8 ± 1.3 | 50.5 | 54.2 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
52.3 ± 1.3 | 50.4 | 54.6 | 1.00 ± 0.04 |
prek-head run --all-files |
52.2 ± 1.4 | 50.3 | 55.1 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
53.1 ± 1.7 | 50.0 | 56.5 | 1.01 ± 0.04 |
prek-head run --all-files |
52.7 ± 1.3 | 50.3 | 55.8 | 1.00 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
14.2 ± 0.2 | 13.7 | 14.6 | 1.01 ± 0.02 |
prek-head run trailing-whitespace --all-files |
14.0 ± 0.2 | 13.6 | 14.6 | 1.00 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
19.5 ± 0.9 | 17.5 | 21.1 | 1.00 |
prek-head run end-of-file-fixer --all-files |
19.5 ± 1.7 | 17.5 | 25.3 | 1.00 ± 0.10 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
5.9 ± 0.2 | 5.6 | 6.2 | 1.02 ± 0.04 |
prek-head run check-json --all-files |
5.8 ± 0.2 | 5.5 | 6.0 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
5.9 ± 0.1 | 5.6 | 6.2 | 1.03 ± 0.03 |
prek-head run check-yaml --all-files |
5.7 ± 0.1 | 5.5 | 6.1 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
5.8 ± 0.2 | 5.5 | 6.3 | 1.03 ± 0.05 |
prek-head run check-toml --all-files |
5.6 ± 0.2 | 5.3 | 6.0 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
5.8 ± 0.2 | 5.4 | 6.2 | 1.01 ± 0.05 |
prek-head run check-xml --all-files |
5.7 ± 0.2 | 5.3 | 6.1 | 1.00 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
10.4 ± 0.6 | 9.5 | 11.8 | 1.02 ± 0.08 |
prek-head run detect-private-key --all-files |
10.2 ± 0.6 | 9.4 | 11.6 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
13.6 ± 0.4 | 12.9 | 14.5 | 1.01 ± 0.04 |
prek-head run fix-byte-order-marker --all-files |
13.6 ± 0.4 | 12.9 | 14.5 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.7 ± 0.1 | 3.6 | 3.8 | 1.04 ± 0.04 |
prek-head install-hooks |
3.6 ± 0.1 | 3.4 | 3.7 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.7 ± 0.1 | 3.6 | 3.7 | 1.03 ± 0.02 |
prek-head install-hooks |
3.5 ± 0.0 | 3.5 | 3.6 | 1.00 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
26.9 ± 0.6 | 26.2 | 28.6 | 1.00 ± 0.03 |
prek-head run |
26.8 ± 0.6 | 26.0 | 28.0 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
6.0 ± 0.2 | 5.8 | 6.3 | 1.04 ± 0.03 |
prek-head run --files '*.json' |
5.8 ± 0.1 | 5.6 | 5.9 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
5.2 ± 0.1 | 5.1 | 5.3 | 1.00 ± 0.03 |
prek-head run --dry-run --all-files |
5.2 ± 0.1 | 4.9 | 5.5 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
8.4 ± 0.2 | 8.1 | 8.8 | 1.05 ± 0.04 |
prek-head run check-hooks-apply --all-files |
8.0 ± 0.1 | 7.9 | 8.3 | 1.00 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.1 ± 0.2 | 8.0 | 8.5 | 1.02 ± 0.02 |
prek-head run check-useless-excludes --all-files |
7.9 ± 0.1 | 7.7 | 8.1 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
7.4 ± 0.1 | 7.3 | 7.7 | 1.01 ± 0.02 |
prek-head run identity --all-files |
7.4 ± 0.1 | 7.2 | 7.8 | 1.00 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4927cdecb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: deb7054f57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
For #2256