You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed the diff against local clis/doubao/utils.ts. The changes address the root cause of #909 comprehensively:
Key improvements verified:
Composer detection hardened: buildDoubaoComposerLocatorScript centralizes 13 selectors with visibility checks and proper element type validation (HTMLTextAreaElement | HTMLInputElement | HTMLElement), replacing the inline candidate loop that could miss edge cases.
Response parsing fixed: The critical change in waitForDoubaoResponse removes the simple beforeSet dedup and replaces it with collectDoubaoTranscriptAdditions, which:
Normalizes sanitization before comparing against beforeLines
Handles prompt contamination in multiline transcripts
Verification detection: detectDoubaoVerificationScript now throws CommandExecutionError early in both sendDoubaoMessage and getCandidate, preventing silent hangs on CAPTCHA/challenge pages.
One observation: The isLikelyTranscriptUiNoise function uses raw vs sanitized comparison but the third parameter promptText isn't used in the function body (seen in the diff). If this is intentional for future use, consider adding a comment; otherwise it might be dead code.
The test coverage (11 new test cases for collectDoubaoTranscriptAdditions) validates the main filtering scenarios well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden the Doubao
askflow so homepage and sidebar chrome are no longer misread as assistant output.Related issue:
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output
Relevant checks run in this worktree:
npm test npm run test:adapter -- clis/doubao/ ./node_modules/.bin/tsc --noEmit npm run buildBuilt-in adapter execution check:
[ { "Role": "User", "Text": "测试一下,只回复OK" }, { "Role": "System", "Text": "No response within 15s. Doubao may still be generating." } ]