fix(plugin): handle EXDEV cross-filesystem rename during install#488
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 27, 2026
Merged
fix(plugin): handle EXDEV cross-filesystem rename during install#488jackwener merged 2 commits intojackwener:mainfrom
jackwener merged 2 commits intojackwener:mainfrom
Conversation
fs.renameSync() fails with EXDEV when source and destination are on different filesystem mount points. This commonly happens because plugin clones land in os.tmpdir() (often /tmp on a tmpfs) while plugins are installed to ~/.opencli/plugins/ (on the root filesystem). Add a moveDir() helper that catches EXDEV and falls back to fs.cpSync() + fs.rmSync(). Applied to both single-plugin and monorepo install paths.
jackwener
force-pushed
the
fix/plugin-exdev-rename
branch
from
bb287b7 to
717f382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fs.renameSync()fails withEXDEVwhen source and destination are on different filesystem mount points. This commonly happens because plugin clones land inos.tmpdir()(often/tmpon a tmpfs) while plugins are installed to~/.opencli/plugins/(on the root filesystem).Fix
Add a
moveDir()helper that catchesEXDEVand falls back tofs.cpSync()+fs.rmSync(). Applied to both single-plugin and monorepo install paths.Testing
All 337 unit tests pass.