fix(plugin): remove legacy LOCK_FILE/MONOREPOS_DIR constants#495
Merged
jackwener merged 1 commit intojackwener:mainfrom Mar 27, 2026
Merged
fix(plugin): remove legacy LOCK_FILE/MONOREPOS_DIR constants#495jackwener merged 1 commit intojackwener:mainfrom
jackwener merged 1 commit intojackwener:mainfrom
Conversation
Remove the module-level LOCK_FILE and MONOREPOS_DIR constants that were computed at load time using os.homedir(). These ignored the HOME environment variable, causing path mismatches when tests use HOME for isolation. All usages now go through getLockFilePath() and getMonoreposDir() which respect process.env.HOME. Updated plugin.test.ts accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
plugin.tshad two parallel path systems:LOCK_FILE,MONOREPOS_DIR) computed at module load time viaos.homedir()getLockFilePath(),getMonoreposDir()) that readprocess.env.HOMEat call timeWhen tests set
HOMEfor isolation, these diverge — the constants still point to the real home, while the functions point to the test directory.Fix
Remove the legacy constants. All code now uses
getLockFilePath()andgetMonoreposDir(). Updatedplugin.test.tsto usegetLockFilePath().Testing
All 337 unit tests pass.