add missing long pageOffset() getter - #1535
Merged
Merged
Conversation
njr-11
reviewed
Aug 20, 2026
njr-11
left a comment
njr-11
left a comment
Member
There was a problem hiding this comment.
I actually left this out intentionally, thinking that it would only be needed by the Data provider, and the Data provider can easily subtract one from the pageNumber(). If we expect this to be helpful for users as well, here are a few review comments,
Member
Author
I think it's certainly useful to clients. It's also more symmetric. |
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Member
Author
|
@njr-11 fixed those two things |
otaviojava
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are missing a getter for the page offset.