Javadoc for NavigableExpression and Path - #1541
Open
njr-11 wants to merge 2 commits into
Open
Conversation
Co-authored-by-AI: IBM Bob 2.0.2
Co-authored-by-AI: IBM Bob 2.0.2
gavinking
reviewed
Aug 22, 2026
Comment on lines
+37
to
+38
| * An {@linkplain Expression expression} that navigates to an attribute of an | ||
| * embeddable or association. |
Member
There was a problem hiding this comment.
Not sure this is the right way to say it.
- I don't think we define the term "embeddable" anywhere in Jakarta Data
- it's not the expression itself that navigates an attribute or association; the expression represents a type which allows such navigation
Member
There was a problem hiding this comment.
it's not the expression itself that navigates an attribute or association; the expression represents a type which allows such navigation
well, actually scratch what I said ... I suppose this is actually correct but somehow I still find it confusing....
| * | ||
| * <p> | ||
| * The {@code navigate} methods accept a metamodel attribute of an intermediate | ||
| * type {@code U} and return a new expression of a more specific subtype, |
Member
There was a problem hiding this comment.
I don't think "more specific subtype" is quite correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Javadoc for NavigableExpression, Path, and one of the Path subclasses. After getting that correct, the same can be applied to the other Path subclasses