Client id secret #135
Open
Client id secret #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the reference to the CocoaPods project from the workspace and added a Package.resolved file for Swift Package Manager, specifying CSV.swift and SwiftyJSON as dependencies. This migrates dependency management from CocoaPods to SwiftPM.
Implements applicationSupportsSecureRestorableState to return true, enabling secure state restoration for the app.
Replaces username/password authentication with OAuth client credentials (Client ID and Client Secret) for Jamf Pro API. Updates UI labels, placeholders, and prompts to reflect the new authentication method. Refactors Keychain storage, login logic, and token management to use client credentials and handle OAuth token responses, including new token and expiration handling. Improves user guidance and error messages for the new authentication flow.
Deleted the base64Credentials(user:password:) function from dataPreparation.swift as it is no longer used in the codebase.
There was a problem hiding this comment.
Pull request overview
This pull request migrates the application's authentication mechanism from username/password terminology to "Client ID" and "Client Secret" to better align with Jamf Pro API Client authentication. The changes encompass UI updates, keychain storage refactoring, dependency management migration from CocoaPods to Swift Package Manager, and security enhancements.
- Refactored KeyChainHelper and related authentication flow to use clientId/clientSecret instead of username/password
- Updated login UI text, placeholders, and prompts to reflect API Client credential terminology
- Migrated from CocoaPods to Swift Package Manager for dependency management
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| The MUT/KeychainHelper.swift | Refactored credential storage to use clientId and clientSecret parameters instead of username and password |
| The MUT/Base.lproj/Main.storyboard | Updated UI elements with "Client ID" and "Client Secret" placeholders and revised login prompt text |
| The MUT/loginWindow.swift | Updated outlet names and credential handling to use clientId/clientSecret terminology |
| The MUT/popPrompt.swift | Revised error messages to reference "API Client credentials" instead of username/password |
| The MUT/AppDelegate.swift | Implemented applicationSupportsSecureRestorableState for enhanced security |
| MUT.xcworkspace/contents.xcworkspacedata | Removed CocoaPods project reference |
| MUT.xcworkspace/xcshareddata/swiftpm/Package.resolved | Added Swift Package Manager dependencies (CSV.swift and SwiftyJSON) |
Files not reviewed (1)
- The MUT.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mike-levenick
commented
Dec 24, 2025
Replaces manual token URL construction with the dataPreparation.generateJpapiURL method for improved consistency and maintainability in the getToken function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the application's authentication flow and related UI to use "Client ID" and "Client Secret" terminology instead of "Username" and "Password." It also updates the keychain helper logic, improves secure state restoration, and makes several minor UI and dependency adjustments.
Authentication Flow and Keychain Updates:
KeyChainHelperto useclientIdandclientSecretinstead ofusernameandpassword, updating all relevant variable names and data handling accordingly. [1] [2]UI and Storyboard Adjustments:
Dependency and Project Configuration:
CSV.swiftandSwiftyJSON) inPackage.resolved. [1] [2]App Delegate Enhancement:
applicationSupportsSecureRestorableState(_:)to returntrue, enhancing app security and state restoration support.Xcode/Storyboard Maintenance: