Skip to content

Remove #yaml tag from generic error message URL - #641

Merged
claudep merged 1 commit into
jazzband:masterfrom
mgrdcm:de-yaml_de_error
May 20, 2026
Merged

Remove #yaml tag from generic error message URL#641
claudep merged 1 commit into
jazzband:masterfrom
mgrdcm:de-yaml_de_error

Conversation

@mgrdcm

@mgrdcm mgrdcm commented May 20, 2026

Copy link
Copy Markdown
Member

This error isn't yaml-specific. Looks like this got committed (without PR?) as part of addressing #524 and perhaps bypassed PR/review: 0a3511f#diff-026edabea10cc8f56b3dc11a795a25d0bdc86ae602fc6649cd30730b5624ba78R336-L353

Possible there are other related changes around this code that should be made too, but seemed like fixing the misleading error message might help a little. Here's another later related commit: b2be12e

This error isn't `yaml`-specific.  Looks like this got committed (without PR?) as part of addressing jazzband#524 and perhaps bypassed PR/review.
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.14%. Comparing base (564619d) to head (a420286).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          29       29           
  Lines        3226     3226           
=======================================
  Hits         3005     3005           
  Misses        221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claudep claudep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks good!

@claudep
claudep merged commit 7503651 into jazzband:master May 20, 2026
22 of 23 checks passed
@hugovk hugovk added the changelog: Changed For changes in existing functionality label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Changed For changes in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants