Don't let the default delimiter override a caller-supplied CSV dialect - #666
Open
Sanjays2402 wants to merge 1 commit into
Open
Don't let the default delimiter override a caller-supplied CSV dialect#666Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
CSVFormat.import_set and export_stream_set unconditionally applied DEFAULT_DELIMITER via kwargs.setdefault. A caller passing dialect= but no explicit delimiter= therefore got the default ',' injected alongside the dialect, and csv gives the standalone delimiter precedence, so the dialect's delimiter was silently ignored. Only apply the default when no dialect was supplied. Adds a regression test covering both the import and export paths with a sniffed ':' dialect. Fixes jazzband#622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #622
CSVFormat.import_setandexport_stream_setalways appliedDEFAULT_DELIMITERthroughkwargs.setdefault, so a caller passingdialect=(but no explicitdelimiter=) got the default,injected alongside it — andcsvgives the standalone delimiter precedence, silently ignoring the dialect's delimiter.Now the default is only applied when no
dialectwas supplied. Regression test covers both the import and export paths with a sniffed:dialect; it fails on master and passes with the fix, and the full suite (181 tests) is green.