Set more appropriate default deadline for Google App Engine requests#278
Open
jstnlef wants to merge 1 commit intojcgregorio:masterfrom
Open
Set more appropriate default deadline for Google App Engine requests#278jstnlef wants to merge 1 commit intojcgregorio:masterfrom
jstnlef wants to merge 1 commit intojcgregorio:masterfrom
Conversation
…on appengine, we really should be using urlfetch.get_default_fetch_deadline() to set the default deadline for requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the library is actually using the urlfetch module when running on appengine, we really should be using
urlfetch.get_default_fetch_deadline()to set the default deadline for fetch requests.