Add support for keyless lookups#5
Open
philomory wants to merge 1 commit intojerakia:masterfrom
magicmemories:feature/support-keyless-lookups
Open
Add support for keyless lookups#5philomory wants to merge 1 commit intojerakia:masterfrom magicmemories:feature/support-keyless-lookups
philomory wants to merge 1 commit intojerakia:masterfrom
magicmemories:feature/support-keyless-lookups
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds supports for keyless lookups by using
""as a lookup key (because Go doesn't really support optional arguments, or passingnilinstead of a string, or anything like that, and I didn't want to break the existing API).An alternative fix would be to just move the key into the LookupOptions struct, which I think would be more elegant, but it'd be a breaking change.