Skip to content

Conversation

@ym
Copy link
Contributor

@ym ym commented Nov 5, 2025

e.g.

image

@ym
Copy link
Contributor Author

ym commented Nov 6, 2025

I can't seem to fix the segfault issue when closing PacketSource, and I can see that other people are having the same issue with GoPacket. I will move the Rx process to a separate process to avoid this issue.

@IDisposable
Copy link
Contributor

IDisposable commented Nov 6, 2025

I can't seem to fix the segfault issue when closing PacketSource, and I can see that other people are having the same issue with GoPacket. I will move the Rx process to a separate process to avoid this issue.

I would hate for us to spin up a process just for that! Can I take a gander and see if I can figure it out? There are some mutex issues I noted, but I haven't even tries to run this code... I might be able to find the issue once I do?

Can you give me the steps to make it segfault and/or the stack trace?

@ym
Copy link
Contributor Author

ym commented Nov 6, 2025

Can you give me the steps to make it segfault and/or the stack trace?

I kinda fixed it, but the solution is quite dirty. If you come up with a cleaner approach, go for it.
I added the details in the latest commit message.

@IDisposable
Copy link
Contributor

Can you give me the steps to make it segfault and/or the stack trace?

I kinda fixed it, but the solution is quite dirty. If you come up with a cleaner approach, go for it. I added the details in the latest commit message.

Looks fine by me :)

@ym
Copy link
Contributor Author

ym commented Nov 10, 2025

I reverted the change to cacheKey, since ttlcache doesn’t handle struct keys properly. It seems to use the memory address (or another non-stable reference) as the key, which causes unexpected behavior.

nvm, it's stupid React key issue :-)

@ym ym marked this pull request as ready for review November 10, 2025 16:55
@ym ym requested a review from IDisposable November 11, 2025 11:00
@ym ym requested review from IDisposable and removed request for IDisposable November 14, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants