-
Notifications
You must be signed in to change notification settings - Fork 258
feat: lldp #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: lldp #948
Conversation
|
I can't seem to fix the segfault issue when closing PacketSource, and I can see that other people are having the same issue with GoPacket. I will move the Rx process to a separate process to avoid this issue. |
I would hate for us to spin up a process just for that! Can I take a gander and see if I can figure it out? There are some mutex issues I noted, but I haven't even tries to run this code... I might be able to find the issue once I do? Can you give me the steps to make it segfault and/or the stack trace? |
I kinda fixed it, but the solution is quite dirty. If you come up with a cleaner approach, go for it. |
Looks fine by me :) |
|
nvm, it's stupid React key issue :-) |
e.g.