-
Notifications
You must be signed in to change notification settings - Fork 258
Applies ESLint code formatting #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
This changes everything ;) It was just a run of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR applies ESLint and Prettier formatting rules across the UI codebase, following current Vite project standards. The changes include splitting the TypeScript configuration into separate app and node configs, upgrading Node to 22.21.1, updating several packages, removing unused dependencies, and applying consistent code formatting (quote styles, spacing, line breaks, trailing commas). The changes are purely stylistic with no intended functional modifications.
Reviewed Changes
Copilot reviewed 125 out of 130 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/tsconfig.json | Restructured to reference split configs |
| ui/tsconfig.app.json | New file with app-specific TypeScript config |
| ui/tsconfig.node.json | Enhanced with additional compiler options |
| ui/src/**/*.ts(x) | Applied consistent formatting: spacing, quotes, line breaks, trailing commas |
| ui/src/keyboardLayouts/*.ts | Standardized semicolons and trailing commas |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This one-time pass will enable us to put the eslint check that PR #491 was attempting to enable :) |
2cc6626 to
c56eb84
Compare
|
Rebased on current dev and conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 126 out of 131 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Rebased |
|
I'd rebase it myself and merge it, but it's on your write protected fork. Could you either give me write permission, so I can rebase it or, rebase it yourself. I promise i'll merge this as soon as you're done. Would love to have this in the codebase <3 |
|
Merged. READY TO MERGE @adamshiervani |
9688265 to
6cce76c
Compare
Move from .cjs to .js file for eslint Allow slightly longer lines Don't force blank lines between import groups (but allow them) Added lint:only and lint:fixonly when no localization needs compiling Eliminated unused lodash.throttle package. Moved the eslint-import-resolver-alias to the devDependences Add missing typescript-eslint to devDependencies Model the split tsconfig*.json for modern vite projects. Upgraded packages.
Bumped devcontainer Bump more packages
Fix merge issue. Final prettier violations cleanup
6cce76c to
f3a437a
Compare
|
The only thing that still looks wrong-ish is |
|
That should be able to be fixed by moving to For some more context: https://github.com/orgs/react-hook-form/discussions/7558#discussioncomment-1982479 |
Summary
Upgraded all the ESLint and enforced the current rule set to get consistent code style across the UI codebase. It primarily consists of changes automatically applied by ESLint and Prettier.
Details