Two patches to make the client work better with a picky resource#105
Open
ferrix wants to merge 2 commits intojoestump:masterfrom
Open
Two patches to make the client work better with a picky resource#105ferrix wants to merge 2 commits intojoestump:masterfrom
ferrix wants to merge 2 commits intojoestump:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a picky backend that has two features not supported by the Client class.
a) It wants JSON in the POST body instead of x-www-form-encoded, so I peek into the headers and don't overwrite Content-Type if it is already set, default behavior remains
b) cares about the Authentication realm bit, I added a parameter that sets the realm in the request, default behavior remains.