Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/selectools/embeddings/anthropic.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,6 @@ def embed_query(self, query: str) -> List[float]:
)
return cast(List[float], response.embeddings[0])

@property
def dimension(self) -> int:
"""
Get the embedding vector dimension.

Returns:
Dimension of embedding vectors
"""
return self._dimension


__stability__ = "beta"

Expand Down
10 changes: 0 additions & 10 deletions src/selectools/embeddings/cohere.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,16 +154,6 @@ def embed_query(self, query: str) -> List[float]:
)
return cast(List[float], response.embeddings[0])

@property
def dimension(self) -> int:
"""
Get the embedding vector dimension.

Returns:
Dimension of embedding vectors
"""
return self._dimension


__stability__ = "beta"

Expand Down
10 changes: 0 additions & 10 deletions src/selectools/embeddings/gemini.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,16 +172,6 @@ def embed_query(self, query: str) -> List[float]:
raise ValueError("No embedding returned")
return response.embeddings[0].values

@property
def dimension(self) -> int:
"""
Get the embedding vector dimension.

Returns:
Dimension of embedding vectors
"""
return self._dimension


__stability__ = "beta"

Expand Down
10 changes: 0 additions & 10 deletions src/selectools/embeddings/openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,16 +146,6 @@ def embed_query(self, query: str) -> List[float]:
"""
return self.embed_text(query)

@property
def dimension(self) -> int:
"""
Get the embedding vector dimension.

Returns:
Dimension of embedding vectors
"""
return self._dimension


__stability__ = "beta"

Expand Down
8 changes: 6 additions & 2 deletions src/selectools/embeddings/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ class EmbeddingProvider(ABC):
across different backend implementations (OpenAI, Anthropic/Voyage, Gemini, Cohere).
"""

# Each concrete provider sets this in __init__ (typically via
# _get_model_dimension()). Declared here so the shared `dimension`
# property below is type-checked against the base class.
_dimension: int

@abstractmethod
def embed_text(self, text: str) -> List[float]:
"""
Expand Down Expand Up @@ -63,15 +68,14 @@ def embed_query(self, query: str) -> List[float]:
pass

@property
@abstractmethod
def dimension(self) -> int:
"""
Get the embedding vector dimension for this model.

Returns:
Integer dimension of embedding vectors
"""
pass
return self._dimension


__stability__ = "beta"
Expand Down
Loading