Add timebased autolap, so far to workouts without gps#1293
Open
jonasoreland wants to merge 7 commits into
Open
Add timebased autolap, so far to workouts without gps#1293jonasoreland wants to merge 7 commits into
jonasoreland wants to merge 7 commits into
Conversation
gerhardol
reviewed
Dec 29, 2025
Collaborator
gerhardol
left a comment
gerhardol
left a comment
There was a problem hiding this comment.
why only in basic and for non GPS?
enable globally instead?
| Context context = requireContext(); | ||
| mDB = DBHelper.getWritableDatabase(context); | ||
| formatter = new Formatter(context); | ||
| prefs = PreferenceManager.getDefaultSharedPreferences(context); |
Collaborator
There was a problem hiding this comment.
The context is ot fixed, so I do not think this can be shared,
|
|
||
| public static void setAutolapTime(Workout w, double seconds) { | ||
| for (StepListEntry s : w.getStepList()) { | ||
| if (s.step.getIntensity() == Intensity.ACTIVE |
Collaborator
There was a problem hiding this comment.
Why limit to these states?
| for (StepListEntry s : w.getStepList()) { | ||
| if (s.step.getIntensity() == Intensity.ACTIVE | ||
| || s.step.getIntensity() == Intensity.COOLDOWN) { | ||
| s.step.setAutolapTime(seconds); |
Collaborator
There was a problem hiding this comment.
If the time is shorter than 10s or so for me, the time start to drift, all notifications take longer time. (in debug)
Just ignore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.